insight-lane / crash-model

Build a crash prediction modeling application that leverages multiple data sources to generate a set of dynamic predictions we can use to identify potential trouble spots and direct timely safety interventions.

https://insightlane.org

MIT License

113 stars 40 forks source link

Fix width bug and point-based features propagation bug #173

Closed j-t-t closed 6 years ago

j-t-t commented 6 years ago

There are two bugs I'm fixing in this PR

Create_segments wasn't adding the point-based features since I accidentally checked in the additional_feats_filename = None line during some testing. This causes the pipeline for cambridge to break when it can't find the feature. So taking that line back out
When trying to do error handling on widths that didn't have any numbers in them (e.g. 't' which I found as a width in Somerville), I stripped out everything that wasn't a number, including decimal points. Fixed that, and wrote a test for the width processing.

codecov[bot] commented 6 years ago

Codecov Report

Merging #173 into master will increase coverage by 0.05%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   39.88%   39.93%   +0.05%     
==========================================
  Files          26       26              
  Lines        2678     2677       -1     
==========================================
+ Hits         1068     1069       +1     
+ Misses       1610     1608       -2