insight-lane / crash-model

Build a crash prediction modeling application that leverages multiple data sources to generate a set of dynamic predictions we can use to identify potential trouble spots and direct timely safety interventions.
https://insightlane.org
MIT License
112 stars 40 forks source link

tool to make smaller maps and some cleanups #186

Closed j-t-t closed 5 years ago

j-t-t commented 5 years ago
codecov[bot] commented 5 years ago

Codecov Report

Merging #186 into master will increase coverage by 0.09%. The diff coverage is 68.08%.

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   43.84%   43.94%   +0.09%     
==========================================
  Files          27       28       +1     
  Lines        2796     2806      +10     
==========================================
+ Hits         1226     1233       +7     
- Misses       1570     1573       +3
terryf82 commented 5 years ago

This looks great and I'm sure we'll have cause to make use of the new map subset feature many times in the future.

The only change I would have made is to call the final parameter to get_buffer radius instead of buff, as passing a buffer to "get_buffer" seems a bit contradictory, but that's just personal preference.

Ready to merge unless anyone else also wants to review?

j-t-t commented 5 years ago

Updated variable names