insight-lane / crash-model

Build a crash prediction modeling application that leverages multiple data sources to generate a set of dynamic predictions we can use to identify potential trouble spots and direct timely safety interventions.
https://insightlane.org
MIT License
113 stars 40 forks source link

Fix to issue with philadelphia onboarding #187

Closed j-t-t closed 6 years ago

j-t-t commented 6 years ago

maybe wait to do a review on this until my other PR as this includes that branch's changes

Workaround for the issue of philadelphia breaking when being onboarded. Also added a test for it.

Also added an option to allow users to pass in a debug argument in get_intersection_buffers to allow it to write the buffers to geojson. I found myself writing code to write them out and then deleting it several times as part of my debugging process, so having this as an option should save time.

codecov[bot] commented 6 years ago

Codecov Report

Merging #187 into master will increase coverage by 0.31%. The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   44.24%   44.55%   +0.31%     
==========================================
  Files          28       28              
  Lines        2805     2819      +14     
==========================================
+ Hits         1241     1256      +15     
+ Misses       1564     1563       -1