insight-lane / crash-model

Build a crash prediction modeling application that leverages multiple data sources to generate a set of dynamic predictions we can use to identify potential trouble spots and direct timely safety interventions.

https://insightlane.org

MIT License

112 stars 40 forks source link

Showcase #218

Closed terryf82 closed 5 years ago

terryf82 commented 5 years ago

Evaluating ability to merge showcase code into master and have a unified viz branch.

codecov[bot] commented 5 years ago

Codecov Report

Merging #218 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   55.73%   55.73%           
=======================================
  Files          34       34           
  Lines        3459     3459           
=======================================
  Hits         1928     1928           
  Misses       1531     1531

terryf82 commented 5 years ago

@alicefeng this should now be ready for merging, can you just double check that everything looks fine from a viz perspective?

I've had to make some small changes to the loading of data for 'standalone' viz mode. The city selector will appear even if there is only one city being run, but then the same code works for showcase / multi-city mode.

The path to config.js is the local directory, but I swap this out in the showcase Dockerfile to point to the S3-hosted version.

terryf82 commented 5 years ago

You should be able to swap to the showcase branch and run it locally, once you generate or modify the config.js file according to the new spec.

On Mon, Jan 14, 2019 at 8:59 AM Alice Feng notifications@github.com wrote:

@alicefeng commented on this pull request.

@terryf82 https://github.com/terryf82 Reading through the code, the changes look good to me. How would I go about running this locally to see how this looks/functions now? Or is the hosted version using this code base?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Data4Democracy/crash-model/pull/218#pullrequestreview-191994908, or mute the thread https://github.com/notifications/unsubscribe-auth/AIYfSHN6GAw43Wq2sGYHaCdYfmOo-vRqks5vC7ozgaJpZM4YoLkM .

terryf82 commented 5 years ago

@alicefeng Can you try this again and see if your local viz loads without error?

shreyapandit commented 5 years ago

I am unable to choose city and the map doesnt load. I compiled and ran the branch through docker:

- docker build --tag datafordemocracy/crash-model:showcase .
- docker run -d -p 8080:8080 --name bcm.local -v `pwd`:/app datafordemocracy/crash-model:showcase

where pwd appends my local path repo

shreyapandit commented 5 years ago