insight-lane / crash-model

Build a crash prediction modeling application that leverages multiple data sources to generate a set of dynamic predictions we can use to identify potential trouble spots and direct timely safety interventions.

https://insightlane.org

MIT License

112 stars 40 forks source link

Fix waze bug #222

Closed j-t-t closed 5 years ago

j-t-t commented 5 years ago

Two things here:

Due to some changes in packages (not anything in our repository), there were negligible differences between expected and actual values of coordinates, so I changed tests to use an almost equal check on some coordinates instead of exact matching
When adding the waze data to segments, I had accidentally dropped the nodes, causing problems downstream. Fixing that here, and adding a test to make sure that the nodes are preserved

codecov[bot] commented 5 years ago

Codecov Report

Merging #222 into master will increase coverage by 0.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   54.16%   54.18%   +0.01%     
==========================================
  Files          32       32              
  Lines        3190     3191       +1     
==========================================
+ Hits         1728     1729       +1     
  Misses       1462     1462