search

insight-lane / crash-model

Build a crash prediction modeling application that leverages multiple data sources to generate a set of dynamic predictions we can use to identify potential trouble spots and direct timely safety interventions.
https://insightlane.org
MIT License
112 stars 40 forks source link

make_canon_dataset needs a check for segment/week level #241

Closed bpben closed 5 years ago

bpben commented 5 years ago

Right now the only place that the yaml config file is checked for whether prediction should be at the segment or week level is in train_model. Right now the make_canon_dataset always groups by date, which will break it if the date field is not properly formatted. I think we need to add a check into make_canon_dataset.

@j-t-t , thoughts?

j-t-t commented 5 years ago

Will be removing week level option

bpben commented 5 years ago

Should we move this to a new issue? Looks like the deprecate week-level should be its own thing, since it also means we need to change config defaults and remove from train_model.

j-t-t commented 5 years ago

Good point, I filed a new task for that, and closing this one.