insight-lane / crash-model

Build a crash prediction modeling application that leverages multiple data sources to generate a set of dynamic predictions we can use to identify potential trouble spots and direct timely safety interventions.

https://insightlane.org

MIT License

112 stars 40 forks source link

Added new city config for NYC #299

Closed spbail closed 3 years ago

spbail commented 4 years ago

Ran pipeline and tested flask app, but doesn't show modes yet in the dropdown menu. Any thoughts why?

codecov[bot] commented 4 years ago

Codecov Report

Merging #299 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files          33       33           
  Lines        3253     3253           
=======================================
  Hits         2060     2060           
  Misses       1193     1193

bpben commented 4 years ago

Sorry for the delay here: Do you mean in the showcase at insightlane.org? I believe we need to update that ourselves to make it show in there. @j-t-t @terryf82

If it's not showing locally, I can try and see why. It might need some kind of additional config.

terryf82 commented 4 years ago

YAML configs (like the one in this P.R) are relevant to running the pipeline and generating output files (predictions & crashes).

Once those have been generated, the process for now is for me to upload them to Google Cloud, create an entry in the JS config and then re-deploy the showcase. @spbail - are the output files available somewhere I can download? (we usually use data.world for sharing but I can grab them from anywhere you like).

spbail commented 4 years ago

@bpben @terryf82 Apologies for the delay. I had to abandon my dev setup on my old laptop, but I will attempt to get this running again next week and will share the output. My question about the dropdown was that the output didn't show up in my local version, so yes, I'm thinking there should be a config I couldn't find to make things show up locally?

j-t-t commented 4 years ago

I would expect the dropdown should work. It's not immediately obvious to me what would be wrong. Can you point me to the crash dataset you're using and I can try to run it using your config on my machine?

bpben commented 4 years ago

@spbail Are you still interested on working to onboard NYC? If not, no worries, do you mind providing us the crash dataset you're working on and we can see if we can finish the onboarding process. By the way, we've move to a new slack if you want to join us there: https://join.slack.com/t/insightlane/shared_invite/zt-ewlvaic7-ymYlps33v2M2~RhC4DFRGg

codecov-commenter commented 3 years ago

Codecov Report

Merging #299 (0e44627) into master (1259061) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   64.02%   64.02%           
=======================================
  Files          33       33           
  Lines        3263     3263           
=======================================
  Hits         2089     2089           
  Misses       1174     1174

spbail commented 3 years ago

Hi all, apologies for abandoning this. Some notes:

I downloaded the collision data from https://data.cityofnewyork.us/Public-Safety/Motor-Vehicle-Collisions-Crashes/
I uploaded a small notebook with some exploration of the data here: https://drive.google.com/file/d/1rBVBs-TMAIrxAwSlz6OBeeljqtp0GXvv/view?usp=sharing
I also pinged you in the new Slack, happy to pair with someone to get this set up.

j-t-t commented 3 years ago

Dropdown seems fine, so merged