Closed bwmcin closed 1 year ago
Hello, @bwmcin. I need to check because, recently, CI was able to build everything with a new naming scheme which enabled uploading to PyPi.
@bwmcin the problem is fixed.
I was able to successfully build Similari with the new updates. Thank you for the quick response.
bwmcin
From: Bitworks LLC @.> Sent: Friday, June 02, 2023 10:55 PM To: insight-platform/Similari @.> Cc: bwmcin @.>; Mention @.> Subject: Re: [insight-platform/Similari] Unable to build--maturin failed, the module name must not contain a minus '-' (Issue #102)
Hello, @bwmcin https://github.com/bwmcin . I need to check because, recently, CI was able to build everything with a new naming scheme which enabled uploading to PyPi.
— Reply to this email directly, https://github.com/insight-platform/Similari/issues/102#issuecomment-1574689493 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/AC3OYU5J25I6XBZZRSEDD4TXJLGTJANCNFSM6AAAAAAYY66WEU unsubscribe. You are receiving this because you were mentioned. https://github.com/notifications/beacon/AC3OYU2FCMY5CFZAMUMWV4DXJLGTJA5CNFSM6AAAAAAYY66WEWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS53PNNK.gif Message ID: < @.> @.>
Following the instructions from https://medium.com/inside-in-sight/high-performance-python-sort-tracker-225c2b507562 resulted in a build failure, with the message maturin failed, the module name must not contain a minus '-' . I edited the pyproject.toml file to change the project name back to similari (no -trackers-rs) and the build worked.