search

insight-platform / Similari

A framework for building high-performance real-time multiple object trackers
Apache License 2.0
207 stars 14 forks source link

No source distributions on PyPi #109

Closed calvinbeeguard closed 8 months ago

calvinbeeguard commented 8 months ago

No source distributions are available pn PyPi making it impossible to upgrade similari-trackers-rs further than version 0.26.5 using pip install --upgrade and so even with the --no-binary or --no-cache-dir options.

bwsw commented 8 months ago

Yes, you are right, no more source distribution. Unfortunately, I'm not planning to change CI/CD to publish the source distribution because it has no practical purpose.

enavarro222 commented 8 months ago

We got that issue on apple M1, either source distribution or compiled code for apple silicon would be great !

bwsw commented 8 months ago

@enavarro222, you can build locally with instructions: https://github.com/insight-platform/Similari?tab=readme-ov-file#build-python-api-in-host-system

The source distribution does not help with the problem because it is a Rust code, and you cannot build it automatically without a toolchain installed. Unfortunately, I do not have a Mac available to run automated or local builds, but nothing prevents from building locally.

enavarro222 commented 8 months ago

Yes, no issue to install it from git repo, it compile fine locally with maturin on m1.

The point is to have "pip install" available for simple integration in larger project (and in that projects CI).

I'm not familiar with github CI, but we may help to test some build automation for M1 target if you want, and have few time to draft such automation...

Also the source distribution in pypi allows pip to compile the code on M1 with simple "pip install".

bwsw commented 8 months ago

@enavarro222 I wonder if it can do it for PyO3/Rust-based source code.

As I see, GitHub added a runner for MacOS M1, so I may try to automate the builds.

bwsw commented 8 months ago

Looks like the build goes normally. I will release the next minor version with builds for MacOS and sdist.

https://github.com/insight-platform/Similari/actions/runs/8001965355/job/21854218309

bwsw commented 8 months ago

@enavarro222 @calvinbeeguard When the build completes, you will have access to MacOS prebuilt wheels and sdist.

https://github.com/insight-platform/Similari/actions/runs/8002068475

enavarro222 commented 8 months ago

Great ! 🎉

Thanks a lot !