search

insightautos / cordova-gmv-barcode-scanner

A Cordova barcode scanning plugin based on the Google Mobile Vision library for iOS & Android.
MIT License
52 stars 77 forks source link

#2 Initial Cropping of Viewfinder, needs more testing. #21

Open fabiomercorillo opened 5 years ago

fabiomercorillo commented 5 years ago

Hello, there is error in CameraSourcePreview.java at 59 row: the correct parameter of first args.optDouble method is 2, not 1

intent.putExtra("ViewFinderHeight", args.optDouble(2, .7));

Best regards

manojchandrashekar commented 4 years ago

@fabiomercorillo Hello. Not a maintainer, but thanks for the PR. I was trying to crop the viewfinder as well.

One question - Does this also take care of the overlay (white rectangle) to fit to the expected cropping size?

I will try the code in the PR soon. Thanks again.