Closed flobiwankenobi closed 5 months ago
Hey Florian, Thanks for this massive contribution! These look great, but I don’t have time to verify and check them for issues. Can we get someone else to check through these and verify they’re good and I’d be happy to merge the pull? Thanks, Forrest On Fri, Jan 24, 2020 at 9:07 AM, Florian Biebel notifications@github.com wrote: @flobiwankenobi [https://github.com/flobiwankenobi] requested your review on: #27 [https://github.com/dealrinc/cordova-gmv-barcode-scanner/pull/27] Some major improvements.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub [https://github.com/dealrinc/cordova-gmv-barcode-scanner/pull/27?email_source=notifications&email_token=AB56E5PTEY24GK3UQY5MLBLQ7MG53A5CNFSM4KLIOHZ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWF6QXVY#event-2977762263] , or unsubscribe [https://github.com/notifications/unsubscribe-auth/AB56E5O6DM6F6P3NFN25BJ3Q7MG53ANCNFSM4KLIOHZQ] .
Some great improvements here, but I think there is still an error in the aspectRatio calculation for the CameraSourcePreview. Rotating a device with the preview up, you can see the distortion.
The preview is stretched horizontally when the phone is in portrait mode, and stretched vertically when the phone is in landscape.
Which devices are causing you problems? There was a lot of distortion on our tested devices, so I made the adjustments.