search

insightautos / cordova-gmv-barcode-scanner

A Cordova barcode scanning plugin based on the Google Mobile Vision library for iOS & Android.
MIT License
52 stars 77 forks source link

Some major improvements #27

Closed flobiwankenobi closed 5 months ago

flobiwankenobi commented 4 years ago
  1. Removed the CocoaPods dependency for iOS because I had some issues with the new CocoaPod Master Repo.
  2. Added interface for all TypeScript users out there
  3. Fixed broken detectorSize for Android
  4. Fixed wrongly calculated aspect ratio for Android
  5. Removed SecondaryActivity which causes some strange behavior (e.g. switching orientation was starting a new camera stream)
forrestmid commented 4 years ago

Hey Florian, Thanks for this massive contribution! These look great, but I don’t have time to verify and check them for issues. Can we get someone else to check through these and verify they’re good and I’d be happy to merge the pull? Thanks, Forrest On Fri, Jan 24, 2020 at 9:07 AM, Florian Biebel notifications@github.com wrote: @flobiwankenobi [https://github.com/flobiwankenobi] requested your review on: #27 [https://github.com/dealrinc/cordova-gmv-barcode-scanner/pull/27] Some major improvements.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub [https://github.com/dealrinc/cordova-gmv-barcode-scanner/pull/27?email_source=notifications&email_token=AB56E5PTEY24GK3UQY5MLBLQ7MG53A5CNFSM4KLIOHZ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWF6QXVY#event-2977762263] , or unsubscribe [https://github.com/notifications/unsubscribe-auth/AB56E5O6DM6F6P3NFN25BJ3Q7MG53ANCNFSM4KLIOHZQ] .

eggbeard commented 4 years ago

Some great improvements here, but I think there is still an error in the aspectRatio calculation for the CameraSourcePreview. Rotating a device with the preview up, you can see the distortion.

The preview is stretched horizontally when the phone is in portrait mode, and stretched vertically when the phone is in landscape.

flobiwankenobi commented 4 years ago

Which devices are causing you problems? There was a lot of distortion on our tested devices, so I made the adjustments.