search

insightautos / cordova-gmv-barcode-scanner

A Cordova barcode scanning plugin based on the Google Mobile Vision library for iOS & Android.
MIT License
52 stars 77 forks source link

Use of UIWebView in GMV will block Apple App Store submissions #28

Open andrewdaye opened 4 years ago

andrewdaye commented 4 years ago

Hi there - thanks for the great plugin.

Apple will stop accepting submissions to the App Store from April 2020 for new apps (Dec 2020 for updates) that reference the UIWebView, as it is deprecated and supposed to be replaced with WKWebView.

Configuring a Cordova project to WKWebViewOnly avoids the Deprecated API email when uploading to App Store Connect, however adding this plugin to the project brings the warning back. It looks like the Google Mobile Vision module has a reference to the UIWebView which causes the warning.

Since Google have replaced this with the ML Toolkit (https://firebase.google.com/docs/ml-kit/ios/read-barcodes ) which no longer has the UIWebView dependency, are there any plans to update this plugin to switch from Google Mobile Vision to the ML Toolkit?

JustWoody commented 4 years ago

Hi there - thanks for the great plugin.

Apple will stop accepting submissions to the App Store from April 2020 for new apps (Dec 2020 for updates) that reference the UIWebView, as it is deprecated and supposed to be replaced with WKWebView.

Configuring a Cordova project to WKWebViewOnly avoids the Deprecated API email when uploading to App Store Connect, however adding this plugin to the project brings the warning back. It looks like the Google Mobile Vision module has a reference to the UIWebView which causes the warning.

Since Google have replaced this with the ML Toolkit (https://firebase.google.com/docs/ml-kit/ios/read-barcodes ) which no longer has the UIWebView dependency, are there any plans to update this plugin to switch from Google Mobile Vision to the ML Toolkit?

Hi Andrew or anyone really, just wanted to check if you had gotten anywhere with resolving this? as just about to attempt to convert to use the ML toolkit, but never done any objective-c before so may take some time?

andrewdaye commented 4 years ago

Hi @JustWoody - sorry I've got very little experience with Obj-C so I can't really help here. Apple clarified that today (Apr 30th, 2020) is the day that new apps will no longer be allowed with UIWebView, and December for updates to existing apps.

andrewdaye commented 4 years ago

Hi @JustWoody (and anyone else with this issue) - I found this development: https://github.com/Ratsoc/cordova-plugin-firebase-ml-kit-barcode-scanner I've tested it and (once I registered my app with Firebase and downloaded the custom GoogleServices-Info.plist) it worked. Uploaded the test build to Apple and did not get the UIWebView warning message. I don't think this is using the latest release, and I prefer the overlay from @forrestmid 's plugin but it solves the immediate issue. In the code it looks like it was based on the GMV plugin.

JustWoody commented 4 years ago

Thanks for sharing

On 29 Jun 2020, at 12:54, andrewdaye notifications@github.com wrote:

Hi @JustWoody https://github.com/JustWoody (and anyone else with this issue) - I found this development: https://github.com/Ratsoc/cordova-plugin-firebase-ml-kit-barcode-scanner https://github.com/Ratsoc/cordova-plugin-firebase-ml-kit-barcode-scanner I've tested it and (once I registered my app with Firebase and downloaded the custom GoogleServices-Info.plist) it worked. Uploaded the test build to Apple and did not get the UIWebView warning message. I don't think this is using the latest release, and I prefer the overlay from @forrestmid https://github.com/forrestmid 's plugin but it solves the immediate issue. In the code it looks like it was based on the GMV plugin.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dealrinc/cordova-gmv-barcode-scanner/issues/28#issuecomment-651067039, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEZ3NOBPM7SJ7OWFLS4NSLRZB6HBANCNFSM4LPJN2BQ.