search

insightindustry / spss-converter

A simple utility that converts SPSS data to / from Pandas DataFrames, CSV, Excel, JSON, YAML, and dict.
https://spss-converter.readthedocs.io/en/latest/
MIT License
9 stars 4 forks source link

Fix call to pyreadstat set_value_labels #7

Closed schanzel closed 2 years ago

schanzel commented 2 years ago

despite the docs stating the contrary, this accepts a metadata_container, not a dict.

codecov[bot] commented 2 years ago

Codecov Report

Merging #7 (ead3c30) into master (0368aad) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   73.61%   73.61%           
=======================================
  Files           5        5           
  Lines         451      451           
  Branches       70       78    +8     
=======================================
  Hits          332      332           
  Misses         83       83           
  Partials       36       36
Impacted Files Coverage Δ
spss_converter/write.py 56.79% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

insightindustry commented 2 years ago

Good catch! I'll merge this into develop and add unit test for this (should have been one there already). Once I get the unit test in place and passing on CI, I'll update and release v.0.1.2. Thanks for the PR!