make sure NULL and character/logical NA are processed to be numeric NA

bzkrouse commented 4 months ago

What changes are proposed in this pull request?

Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #' resolves #191

Pre-review Checklist (if item does not apply, mark is as complete)

[x] All GitHub Action workflows pass with a :white_check_mark:
[x] PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
[x] If a bug was fixed, a unit test was added.
[x] Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
[x] Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

[ ] If a bug was fixed, a unit test was added.
[ ] Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
[ ] Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

[ ] Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
[ ] All GitHub Action workflows pass with a :white_check_mark:
[ ] Approve Pull Request
[ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".

github-actions[bot] commented 4 months ago

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  ----------------------
R/apply_statistic_fmt_fn.R        63       2  96.83%   92, 172
R/ard_attributes.R                28       0  100.00%
R/ard_categorical.R              343      15  95.63%   110, 205, 517-532, 568
R/ard_complex.R                   32       0  100.00%
R/ard_continuous.R               174       4  97.70%   104, 188-189, 287
R/ard_dichotomous.R               65       2  96.92%   48, 136
R/ard_hierarchical.R              73       0  100.00%
R/ard_missing.R                   16       0  100.00%
R/ard_stack.R                     51       0  100.00%
R/as_nested_list.R                41       1  97.56%   18
R/bind_ard.R                      19       1  94.74%   49
R/check_ard_structure.R           26       1  96.15%   24
R/check_pkg_installed.R          100       1  99.00%   157
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            15       1  93.33%   73
R/nest_for_ard.R                  69       1  98.55%   54
R/print_ard_conditions.R          72      65  9.72%    61-178
R/print.R                         71       0  100.00%
R/process_selectors.R             98       0  100.00%
R/replace_null_statistic.R        10       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shuffle_ard.R                  131       1  99.24%   265
R/summary_functions.R             55       1  98.18%   89
R/tidy_ard_order.R                23       0  100.00%
R/tidy_as_ard.R                   38      11  71.05%   86-96
R/utils.R                         24       0  100.00%
TOTAL                           1688     107  93.66%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/shuffle_ard.R       +3       0  +0.02%
TOTAL                 +3       0  +0.01%

Results for commit: 81840b7a3434d6603462db0cb3ccd1df319f2154

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 4 months ago

Unit Tests Summary

1 files 75 suites 12s :stopwatch: 73 tests 45 :white_check_mark: 28 :zzz: 0 :x: 156 runs 115 :white_check_mark: 41 :zzz: 0 :x:

Results for commit 81840b7a.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Unit Test Performance Difference

Additional test case details

| Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | shuffle_ard | 👶 | | $+0.01$ | shuffle_ard_doesn_t_trim_off_NULL_NA_values |

Results for commit 036831bbaae2cee4ff3334e90faa489664272c30

♻️ This comment has been updated with latest results.

insightsengineering / cards