Add functions to specify correct cli call env

edelarua commented 6 months ago

What changes are proposed in this pull request?

Added functions set_cli_abort_call and get_cli_abort_call to specify the correct call environment in cli error messages. (#42, @edelarua)

Closes #42

Pre-review Checklist (if item does not apply, mark is as complete)

[x] All GitHub Action workflows pass with a :white_check_mark:
[x] PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
[x] If a bug was fixed, a unit test was added.
[x] Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
[x] Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

[x] If a bug was fixed, a unit test was added.
[x] Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
[x] Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

[ ] Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
[ ] All GitHub Action workflows pass with a :white_check_mark:
[ ] Approve Pull Request
[ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".

github-actions[bot] commented 6 months ago

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------
R/apply_fmt_fn.R                  68       2  97.06%   96, 176
R/ard_attributes.R                29       0  100.00%
R/ard_categorical.R              347      17  95.10%   112, 212, 372-373, 529-544, 578
R/ard_complex.R                   33       0  100.00%
R/ard_continuous.R               175       4  97.71%   106, 188-189, 287
R/ard_dichotomous.R               66       2  96.97%   50, 136
R/ard_hierarchical.R              75       0  100.00%
R/ard_missing.R                   17       0  100.00%
R/ard_stack.R                     51       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      22       3  86.36%   51-53
R/check_ard_structure.R           27       1  96.30%   26
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            16       1  93.75%   75
R/nest_for_ard.R                  70       1  98.57%   56
R/print_ard_conditions.R          75      66  12.00%   61-177
R/print.R                         72       0  100.00%
R/process_selectors.R            114       0  100.00%
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shuffle_ard.R                  132       1  99.24%   267
R/summary_functions.R             58       1  98.28%   91
R/tidy_ard_order.R                25       0  100.00%
R/tidy_as_ard.R                   39      11  71.79%   88-98
R/utils.R                         24       0  100.00%
TOTAL                           1638     110  93.28%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  --------
R/apply_fmt_fn.R                 +5       0  +0.23%
R/ard_attributes.R               +1       0  +100.00%
R/ard_complex.R                  +1       0  +100.00%
R/ard_continuous.R               +1       0  +0.01%
R/ard_dichotomous.R              +1       0  +0.05%
R/ard_hierarchical.R             +2       0  +100.00%
R/ard_missing.R                  +1       0  +100.00%
R/ard_stack.R                    +1       0  +100.00%
R/as_nested_list.R                0      -1  +2.44%
R/bind_ard.R                     +3      +2  -8.37%
R/check_ard_structure.R          +1       0  +0.14%
R/get_ard_statistics.R           +1       0  +0.42%
R/nest_for_ard.R                 +1       0  +0.02%
R/print_ard_conditions.R         +3      +1  +2.28%
R/print.R                        +1       0  +100.00%
R/process_selectors.R            +4       0  +100.00%
R/replace_null_statistic.R       +1       0  +100.00%
R/shuffle_ard.R                  +1       0  +0.01%
R/summary_functions.R            +3       0  +0.09%
R/tidy_ard_order.R               +2       0  +100.00%
R/tidy_as_ard.R                  +1       0  +0.74%
TOTAL                           +35      +2  -0.19%

Results for commit: 7bbe2f1be18f83683647e3808ea024a831fb4ff1

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 6 months ago

Unit Tests Summary

1 files 79 suites 11s :stopwatch: 77 tests 49 :white_check_mark: 28 :zzz: 0 :x: 163 runs 121 :white_check_mark: 42 :zzz: 0 :x:

Results for commit 7bbe2f1b.

:recycle: This comment has been updated with latest results.

edelarua commented 6 months ago

@ddsjoberg should I propagate these changes to the file in the standalone repo?

ddsjoberg commented 6 months ago

@ddsjoberg should I propagate these changes to the file in the standalone repo?

@edelarua I think it's ok to iron out the details here, but yes, we'll need to migrate the changes to the standalone repo

edelarua commented 5 months ago

Ready for another review!

Please see https://github.com/ddsjoberg/standalone/pull/7 and https://github.com/insightsengineering/cardx/pull/112 as well.

edelarua commented 5 months ago

The changes here also look great! Thanks!!

insightsengineering / cards