fixing order of strata variables in `ard_categorical(strata)`

ddsjoberg commented 2 months ago

What changes are proposed in this pull request?

Corrected order that ard_categorical(strata) columns would appear in the ARD results. Previously, they appeared in the order they appeared in the original data, and now they are sorted properly. (#221)

Reference GitHub issue associated with pull request. e.g., 'closes #' closes #221

FYI @Nolan-Steed

Pre-review Checklist (if item does not apply, mark is as complete)

[x] All GitHub Action workflows pass with a :white_check_mark:
[x] PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
[x] If a bug was fixed, a unit test was added.
[x] Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
[x] Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

[x] If a bug was fixed, a unit test was added.
[x] Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
[x] Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

[x] Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
[x] All GitHub Action workflows pass with a :white_check_mark:
[x] Approve Pull Request
[ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".

github-actions[bot] commented 2 months ago

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------
R/apply_fmt_fn.R                  63       2  96.83%   92, 172
R/ard_attributes.R                28       0  100.00%
R/ard_categorical.R              347      17  95.10%   110, 205, 366-367, 525-540, 576
R/ard_complex.R                   32       0  100.00%
R/ard_continuous.R               174       4  97.70%   104, 188-189, 287
R/ard_dichotomous.R               65       2  96.92%   48, 136
R/ard_hierarchical.R              73       0  100.00%
R/ard_missing.R                   16       0  100.00%
R/ard_stack.R                     50       0  100.00%
R/as_nested_list.R                41       1  97.56%   18
R/bind_ard.R                      19       1  94.74%   49
R/check_ard_structure.R           26       1  96.15%   24
R/check_pkg_installed.R           83       2  97.59%   99, 104
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            15       1  93.33%   73
R/nest_for_ard.R                  69       1  98.55%   54
R/print_ard_conditions.R          72      65  9.72%    61-178
R/print.R                         71       0  100.00%
R/process_selectors.R            110       0  100.00%
R/replace_null_statistic.R        10       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shuffle_ard.R                  131       1  99.24%   265
R/summary_functions.R             55       1  98.18%   89
R/tidy_ard_order.R                23       0  100.00%
R/tidy_as_ard.R                   38      11  71.05%   86-96
R/utils.R                         24       0  100.00%
TOTAL                           1686     110  93.48%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  -------
R/ard_categorical.R       +4      +2  -0.53%
TOTAL                     +4      +2  -0.10%

Results for commit: 5a61fce1468c7d13edf186255194c97a8d35c8af

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 2 months ago

Unit Tests Summary

1 files 79 suites 12s :stopwatch: 77 tests 49 :white_check_mark: 28 :zzz: 0 :x: 163 runs 120 :white_check_mark: 43 :zzz: 0 :x:

Results for commit 5a61fce1.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

Unit Test Performance Difference

Additional test case details

| Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | ard_categorical | 👶 | | $+0.00$ | ard_categorical_strata_returns_results_in_proper_order |

Results for commit e647ca6407dbc90f9d9a1977209a7b5f276e660a

♻️ This comment has been updated with latest results.

Nolan-Steed commented 2 months ago

Hi @ddsjoberg I wasn't sure if you wanted to do your manual testing on your end that you mentioned in our meeting before we merge this or not?

ddsjoberg commented 2 months ago

thank you @Nolan-Steed !

insightsengineering / cards