insightsengineering / cards

CDISC Analysis Results Data
https://insightsengineering.github.io/cards/
24 stars 0 forks source link

211 ard attributes gen #238

Closed rparmm closed 2 months ago

rparmm commented 2 months ago

What changes are proposed in this pull request?

Provide more detail here as needed.

Reference GitHub issue associated with pull request. Closes #211 by converting ard_attributes into an S3 generic with a method for data.frame objects. Additionally, default method is added to error when any object other than data.frame class is passed.


Pre-review Checklist (if item does not apply, mark is as complete)

Reviewer Checklist (if item does not apply, mark is as complete)

When the branch is ready to be merged:

github-actions[bot] commented 2 months ago

CLA Assistant Lite bot ✅ All contributors have signed the CLA

github-actions[bot] commented 2 months ago

Unit Tests Summary

  1 files   82 suites   12s :stopwatch:  80 tests  51 :white_check_mark: 29 :zzz: 0 :x: 166 runs  123 :white_check_mark: 43 :zzz: 0 :x:

Results for commit 55485cd4.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

Unit Test Performance Difference

Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | ard_attributes | 👶 | | $+0.04$ | ard_attributes_errors_when_there_is_no_dataframe |

Results for commit d11cdce43c0f13d5bfa7d87e7a44f81ee890c8d2

♻️ This comment has been updated with latest results.

rparmm commented 2 months ago

I have read the CLA Document and I hereby sign the CLA

github-actions[bot] commented 2 months ago

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------
R/apply_fmt_fn.R                  83      16  80.72%   97-104, 186-193
R/ard_attributes.R                32       0  100.00%
R/ard_categorical.R              347      17  95.10%   112, 212, 372-373, 529-544, 578
R/ard_complex.R                   33       0  100.00%
R/ard_continuous.R               175       4  97.71%   106, 188-189, 287
R/ard_dichotomous.R               66       2  96.97%   50, 136
R/ard_hierarchical.R              81       0  100.00%
R/ard_missing.R                   17       0  100.00%
R/ard_stack.R                     51       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      22       3  86.36%   51-53
R/check_ard_structure.R           27       1  96.30%   26
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            16       1  93.75%   75
R/nest_for_ard.R                  70       1  98.57%   56
R/print_ard_conditions.R          75      66  12.00%   58-174
R/print.R                         72       0  100.00%
R/process_selectors.R            123       0  100.00%
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shuffle_ard.R                  132       1  99.24%   267
R/summary_functions.R             58       1  98.28%   91
R/tidy_ard_order.R                25       0  100.00%
R/tidy_as_ard.R                   39      11  71.79%   88-98
R/utils.R                         24       0  100.00%
TOTAL                           1671     124  92.58%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  --------
R/ard_attributes.R       +3       0  +100.00%
TOTAL                    +3       0  +0.01%

Results for commit: 55485cd4ef0f89a6cdf584aa002cd34e1fdf84da

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results