Passing `ard_stack(by)` arg to `ard_missing()` when `.missing=TRUE`

ddsjoberg commented 4 months ago

What changes are proposed in this pull request?

Bug fix where ard_stack(by) argument was not passed to ard_missing() when ard_stack(.missing=TRUE). (#244)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #' closes #244

Pre-review Checklist (if item does not apply, mark is as complete)

[x] All GitHub Action workflows pass with a :white_check_mark:
[x] PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
[x] If a bug was fixed, a unit test was added.
[x] Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
[x] Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

[ ] If a bug was fixed, a unit test was added.
[ ] Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
[ ] Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

[ ] Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
[ ] All GitHub Action workflows pass with a :white_check_mark:
[ ] Approve Pull Request
[ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".

github-actions[bot] commented 4 months ago

Unit Tests Summary

1 files 85 suites 12s :stopwatch: 83 tests 52 :white_check_mark: 31 :zzz: 0 :x: 172 runs 127 :white_check_mark: 45 :zzz: 0 :x:

Results for commit 13737f73.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------
R/apply_fmt_fn.R                  83      16  80.72%   97-104, 186-193
R/ard_attributes.R                32       0  100.00%
R/ard_categorical.R              347      17  95.10%   112, 212, 372-373, 529-544, 578
R/ard_complex.R                   33       0  100.00%
R/ard_continuous.R               175       4  97.71%   106, 188-189, 287
R/ard_dichotomous.R               66       2  96.97%   50, 136
R/ard_hierarchical.R              81       0  100.00%
R/ard_missing.R                   17       0  100.00%
R/ard_stack.R                     59       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      22       3  86.36%   51-53
R/check_ard_structure.R           27       1  96.30%   26
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            16       1  93.75%   75
R/nest_for_ard.R                  70       1  98.57%   56
R/print.R                         72       0  100.00%
R/print_ard_conditions.R          75      66  12.00%   60-176
R/process_selectors.R            123       0  100.00%
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shuffle_ard.R                  134       1  99.25%   268
R/summary_functions.R             58       1  98.28%   91
R/tidy_ard_order.R                25       0  100.00%
R/tidy_as_ard.R                   39      11  71.79%   88-98
R/utils.R                         24       0  100.00%
TOTAL                           1681     124  92.62%

Diff against main

Filename         Stmts    Miss  Cover
-------------  -------  ------  --------
R/ard_stack.R       +8       0  +100.00%
TOTAL               +8       0  +0.04%

Results for commit: 13737f7334fa44413f17343e5b488925a646e171

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 4 months ago

Unit Test Performance Difference

Test Suite	$Status$	Time on `main`	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
selectors	💚	$1.21$	$-1.20$	$0$	$0$	$0$	$0$

Additional test case details

| Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | ard_stack | 👶 | | $+0.00$ | ard_stack_messaging | | ard_stack | 💔 | $2.69$ | $+1.09$ | ard_stack_works | | selectors | 💚 | $1.21$ | $-1.20$ | selectors_work |

Results for commit fad94fc37fb346653cff1f899ed1b0041d7c65b8

♻️ This comment has been updated with latest results.

ddsjoberg commented 4 months ago

@bzkrouse I am going to go ahead and merge so I can keep working on another project that this uses. but we can DEFINITELY discuss later and change as needed.

insightsengineering / cards