insightsengineering / formatters

A framework for creating listings of raw data that include specialized formatting, headers, footers, referential footnotes, and pagination.
https://insightsengineering.github.io/formatters/
Other
15 stars 6 forks source link

Fixing infinite loop for specific strings (e.g. "10 . 4", width of 2) #231

Closed Melkiades closed 9 months ago

Melkiades commented 9 months ago

Fixes #230

github-actions[bot] commented 9 months ago

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------
R/format_value.R       193      13  93.26%   88, 104-111, 191, 210, 281, 403, 414, 422
R/generics.R           105       7  93.33%   454, 466, 499, 528, 652-658
R/labels.R              55       7  87.27%   49, 55, 64, 105, 133, 142, 146
R/matrix_form.R        469      31  93.39%   425-426, 521, 534-537, 556, 588, 682-683, 698-703, 733-736, 769-770, 802-803, 835, 907, 958, 1009, 1012, 1016
R/mpf_exporters.R      142      14  90.14%   2, 85-87, 185, 225, 230, 413, 416, 422-425, 463
R/page_size.R           45       1  97.78%   171
R/pagination.R         560      29  94.82%   437, 509, 630-631, 636, 699-700, 721-731, 1035, 1042, 1070-1077, 1223-1224, 1236-1237, 1251-1252
R/tostring.R           571      38  93.35%   29-34, 91, 143, 212, 246, 254, 290, 347-350, 443-447, 454-459, 537, 644-645, 863, 878, 973, 1025, 1066, 1111, 1166, 1173
R/utils.R                3       0  100.00%
TOTAL                 2143     140  93.47%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  -------
R/tostring.R       +3       0  +0.04%
TOTAL              +3       0  +0.01%

Results for commit: 2d21bbe862c2200df543e92064a1bf27f0400765

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 9 months ago

Unit Tests Summary

    1 files      4 suites   7s :stopwatch:   36 tests   36 :heavy_check_mark: 0 :zzz: 0 :x: 240 runs  240 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit 2d21bbe8.