Fix oneliner error and addition of `basic_listing_mf` for testing

[Melkiades]

Fixes #259 and #248 and https://github.com/insightsengineering/rlistings/issues/195

[github-actions[bot]]

Unit Tests Summary

  1 files    5 suites   8s :stopwatch:  41 tests  41 :white_check_mark: 0 :zzz: 0 :x: 280 runs  280 :white_check_mark: 0 :zzz: 0 :x:

Results for commit b91f1193.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
listings	👶		$+0.50$	$+25$	$0$	$0$	$0$

Additional test case details

| Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | exporters | 👶 | | $+0.41$ | export_as_pdf_works | | listings | 👶 | | $+0.13$ | basic_listing_mf_respect_core_modifications_from_table_matrix_form | | listings | 👶 | | $+0.29$ | listings_are_correctly_paginated_when_a_wrapping_happens_on_non_dominant_keycol | | listings | 👶 | | $+0.08$ | regression_test_for_oneline_listing_pagination |

Results for commit 09d0ff311ed7ec495477873cd335ebaafc5de8c6

♻️ This comment has been updated with latest results.

[Melkiades]

Hi @Melkiades , seems the test is failing, can you update the test please. Thanks!

Now the bug should be fixed. I added tests for #243 after having added a way to get a fake listing here in formatters for tests

[github-actions[bot]]

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       194      12  93.81%   88, 104-111, 191, 304, 404, 415, 423
R/generics.R           105       7  93.33%   454, 466, 499, 528, 652-658
R/labels.R              55       7  87.27%   49, 55, 64, 105, 133, 142, 146
R/matrix_form.R        552      50  90.94%   103, 455-456, 544, 557-560, 579, 611, 705-706, 721-726, 756-759, 792-793, 825-826, 870, 1033, 1057-1079, 1121, 1172, 1175, 1179
R/mpf_exporters.R      236      19  91.95%   2, 83-85, 193, 233, 238, 421, 424, 430-433, 471, 542-545, 558
R/page_size.R           45       1  97.78%   174
R/pagination.R         610      49  91.97%   250, 302-305, 407-420, 582, 766-767, 788-798, 996-1012, 1132, 1139, 1323-1324, 1336-1337, 1351-1352
R/tostring.R           600      55  90.83%   29-34, 91, 143, 212, 246, 254, 290, 347-350, 443-447, 450-453, 460-465, 542, 681-682, 747-754, 811-815, 899, 914, 1009, 1061, 1102, 1147, 1202, 1209
R/utils.R                3       0  100.00%
TOTAL                 2400     200  91.67%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  -------
R/format_value.R         0      -1  +0.52%
R/matrix_form.R        +50      -2  +1.30%
R/mpf_exporters.R        0     -83  +35.17%
R/pagination.R           0      -4  +0.66%
TOTAL                  +50     -90  +4.01%

Results for commit: b91f1193dc4c3aafe47482e5c81dc0ee72e1d0f6

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results