search

insightsengineering / formatters

A framework for creating listings of raw data that include specialized formatting, headers, footers, referential footnotes, and pagination.
https://insightsengineering.github.io/formatters/
Other
15 stars 6 forks source link

Add code of conduct #268

Closed martincadek closed 5 months ago

martincadek commented 5 months ago

Closes https://github.com/insightsengineering/formatters/issues/238

github-actions[bot] commented 5 months ago

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       194      12  93.81%   88, 104-111, 189, 301, 401, 412, 420
R/generics.R           105       7  93.33%   454, 466, 499, 528, 652-658
R/labels.R              55       7  87.27%   49, 55, 64, 105, 133, 142, 146
R/matrix_form.R        552      50  90.94%   103, 455-456, 544, 557-560, 579, 611, 705-706, 721-726, 756-759, 792-793, 825-826, 870, 1033, 1057-1079, 1121, 1172, 1175, 1179
R/mpf_exporters.R      238      19  92.02%   2, 90-92, 201, 241, 246, 429, 432, 438-441, 479, 551-554, 567
R/page_size.R           45       1  97.78%   172
R/pagination.R         634      49  92.27%   250, 302-305, 407-420, 582, 765-766, 787-797, 1000-1016, 1148, 1155, 1362-1363, 1375-1376, 1390-1391
R/tostring.R           586      49  91.64%   41, 93, 162, 196, 204, 240, 297-300, 393-397, 400-403, 410-415, 492, 631-632, 697-704, 761-765, 849, 864, 958, 1010, 1051, 1096, 1151, 1158
R/utils.R                3       0  100.00%
R/zzz.R                 17       6  64.71%   29-34
TOTAL                 2429     200  91.77%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: b58d2607bf5fe381a18fc9038f77458755cc4e8d

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 5 months ago

Unit Tests Summary

  1 files    5 suites   9s :stopwatch:  43 tests  43 :white_check_mark: 0 :zzz: 0 :x: 295 runs  295 :white_check_mark: 0 :zzz: 0 :x:

Results for commit b58d2607.

:recycle: This comment has been updated with latest results.

martincadek commented 5 months ago

Thansk for the notices @shajoezhu Changes submited, checks passed.

shajoezhu commented 5 months ago

hi @martincadek , thanks for the PR, the lintr check is failing, can you please resolve that. thanks!

https://github.com/insightsengineering/formatters/actions/runs/8286491619/job/22676608465

hi @cicdguy and @walkowif , I was a bit puzzled with this failed check for lintr, this was a direct copy from rtables, but it never failed on the rtables side, and it was picked up here.

cicdguy commented 5 months ago

hi @cicdguy and @walkowif , I was a bit puzzled with this failed check for lintr, this was a direct copy from rtables, but it never failed on the rtables side, and it was picked up here.

Likely due to new linter rules from the markdown linter? These are the issues reported:

CODE_OF_CONDUCT.md:58:44 MD034/no-bare-urls Bare URL used [Context: "support@github.com"]
CODE_OF_CONDUCT.md:76:42 MD047/single-trailing-newline Files should end with a single newline character