261 truetype pag new

[gmbecker]

Adds the concept of font-based width (number of spaces in the font setting) to wrapping and pagination logic. Lays foundation for upcoming PRs in rtables and rlistings repos.

[gmbecker]

The spell check results are purely false-positives from what I can see

[github-actions[bot]]

CLA Assistant Lite bot ✅ All contributors have signed the CLA

[Melkiades]

The spell check results are purely false-positives from what I can see

Code should be between ` and truetype should be one (does it have hypen?) the rest may be added to the spelling

df           MatrixPrintForm.Rd:60
listOrNULL   MatrixPrintForm.Rd:62
monospace    export_as_pdf.Rd:119
             nchar_ttype.Rd:19,39
             tostring.Rd:53
truetype     export_as_pdf.Rd:119
             nchar_ttype.Rd:41,44
             tostring.Rd:53
Truetype     wrap_string_ttype.Rd:6,46
unrounded    nchar_ttype.Rd:[26](https://github.com/insightsengineering/formatters/actions/runs/8333697785/job/22815864386?pr=270#step:9:29)

[Melkiades]

CLA Assistant Lite bot: 🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement. You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.

I have read the CLA Document and I hereby sign the CLA

0 out of 2 committers have signed the CLA.❌ @gmbecker❌ @MelkiadesYou can retrigger this bot by commenting recheck in this Pull Request

@cicdguy @shajoezhu how can we sign the CLA?

[Melkiades]

I have read the CLA Document and I hereby sign the CLA

[Melkiades]

recheck

[Melkiades]

@gmbecker could you also fix the lintr warnings please? ^^ https://github.com/insightsengineering/formatters/actions/runs/8356002418/job/22872204679?pr=270 I think it is only a matter of code style (like extra spacing etc)

[edelarua]

Documentation/styling/lint is now fixed.

FYI @Melkiades this PR causes breaking changes in rtables that will need to be addressed.

[gmbecker]

I have read the CLA Document and I hereby sign the CLA

[gmbecker]

Documentation/styling/lint is now fixed.

FYI @Melkiades this PR causes breaking changes in rtables that will need to be addressed.

This should only be the case until the rtables PR is also in place, but it looks like that never got filed, or was deleted, I'm not sure. The relevant branch exists in my fork, though, either way

[Melkiades]

Documentation/styling/lint is now fixed. FYI @Melkiades this PR causes breaking changes in rtables that will need to be addressed.

This should only be the case until the rtables PR is also in place, but it looks like that never got filed, or was deleted, I'm not sure. The relevant branch exists in my fork, though, either way

it is not this, right? https://github.com/insightsengineering/rtables/pull/819 I cannot see any connected PR to this one (also not between the closed ones). If it is between your PRs in the fork, do not hesitate to send the MR ;)

[gmbecker]

There isn't a PR for it, though you can a state of it here: https://github.com/gmbecker/rtables/tree/261_truetype_pag

The issue, as you can see, is that there is quite a bit of divergence caused by the doc stuff that I haven't had time to resolve. I'm going to look at it some today and see what I can get working

[gmbecker]

The corresponding rtables PR now exists: insightsengineering/rtables#865

I will create the one for rlistings shortly

[gmbecker]

check failure should be resolved by latest commit

[shajoezhu]

can we close this one now?

[gmbecker]

@Melkiades if you're satisfied the comments have all been addressed please feel free to close this