insightsengineering / formatters

A framework for creating listings of raw data that include specialized formatting, headers, footers, referential footnotes, and pagination.
https://insightsengineering.github.io/formatters/
Other
15 stars 6 forks source link

Adding more details to test mock examples #276

Closed Melkiades closed 4 months ago

Melkiades commented 4 months ago

This PR mainly adds details to basic_matrix_form. Fix for #187 will be reported into {rtables} from https://github.com/insightsengineering/rtables/issues/844

@shajoezhu Only dependency for this PR was supposedly {rlistings} but no breaking changes afaik

github-actions[bot] commented 4 months ago

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       194      12  93.81%   88, 105-112, 187, 296, 396, 407, 415
R/generics.R           108       8  92.59%   460, 472, 503, 533, 641, 665-672
R/labels.R              55       7  87.27%   51, 57, 66, 107, 133, 142, 146
R/matrix_form.R        635      42  93.39%   102, 431-432, 511, 523-526, 544, 575, 664-665, 679-684, 714-717, 746-747, 777-778, 860-861, 888, 916, 967, 1123, 1159, 1162-1166, 1213, 1261, 1264, 1268
R/mpf_exporters.R      260      18  93.08%   2, 96-98, 143, 179, 220, 225, 402-408, 412, 415, 453, 548
R/page_size.R           45       1  97.78%   171
R/pagination.R         676      38  94.38%   300-303, 404-417, 502, 577, 768-769, 789-798, 990-991, 1174, 1180, 1259, 1389-1390, 1402-1403, 1417-1418
R/tostring.R           586      49  91.64%   40, 92, 162, 195, 203, 239, 296-299, 380-384, 387-390, 397-402, 479, 618-619, 684-691, 740-744, 828, 843, 936, 969, 1010, 1051, 1105, 1112
R/utils.R                3       0  100.00%
R/zzz.R                 17       6  64.71%   28-33
TOTAL                 2579     181  92.98%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/matrix_form.R      +75      +4  +0.17%
R/pagination.R        +6       0  +0.05%
TOTAL                +81      +4  +0.07%

Results for commit: 4a7026cefc616d167d43679ddd8dcc44c592f0df

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 4 months ago

Unit Tests Summary

  1 files    8 suites   15s :stopwatch:  48 tests  48 :white_check_mark: 0 :zzz: 0 :x: 335 runs  335 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 4a7026ce.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
matrix_form 👶 $+0.06$ $+9$ $0$ $0$ $0$
print 👶 $+0.09$ $+4$ $0$ $0$ $0$
ref_fnotes 👶 $+0.01$ $+3$ $0$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | formatters | 💀 | $0.01$ | $-0.01$ | reorder_ref_fnotes_orders_referential_footnotes_correctly | | matrix_form | 👶 | | $+0.06$ | matrix_form_works_with_and_without_indentation | | print | 👶 | | $+0.09$ | toString_works_with_and_without_indentation | | ref_fnotes | 👶 | | $+0.01$ | reorder_ref_fnotes_orders_referential_footnotes_correctly | | table_inset and titles and footers word wrapping | 💀 | $0.02$ | $-0.02$ | auto_works_with_inset_and_col_gap | | table_inset and titles and footers word wrapping | 👶 | | $+0.02$ | auto_wrapping_works_with_inset_and_col_gap | | table_inset and titles and footers word wrapping | 💀 | $0.02$ | $-0.02$ | tf_wordwrap_and_table_inset_work_including_together_ | | table_inset and titles and footers word wrapping | 👶 | | $+0.03$ | tf_wrap_and_table_inset_work_including_together_ | | table_inset and titles and footers word wrapping | 💀 | $0.02$ | $-0.02$ | works_with_words_that_are_too_big_no_warning_ | | table_inset and titles and footers word wrapping | 👶 | | $+0.02$ | wrapping_works_with_words_that_are_too_big_no_warning_ |

Results for commit 46002ff67890fe8851fc3f8ac38078ff74528f39

♻️ This comment has been updated with latest results.