Custom formatting function and handling of na_str when using a formatting function

insightsengineering / formatters

A framework for creating listings of raw data that include specialized formatting, headers, footers, referential footnotes, and pagination.

https://insightsengineering.github.io/formatters/

Other

15 stars 6 forks source link

Custom formatting function and handling of na_str when using a formatting function #280

Closed iaugusty closed 2 months ago

iaugusty commented 3 months ago

Please find some proposed extra features for formatters package.

main features of custom formatting function:

xx notation not restricted to predefined ones
For 2 and 3-d stats, the precision of each stat does not have to be the same to all, eg xx.x (xx.xx) for mean (sd)
flexible string notation, not restricted to predefined strings

format_value: also allow na_str to be passed onto a custom formatting function when na_str is a parameter of the function

We are open to other proposals for the naming of the proposed custom functions. Also open to discuss anything else included in this PR.

github-actions[bot] commented 3 months ago

CLA Assistant Lite bot ✅ All contributors have signed the CLA

iaugusty commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

iaugusty commented 2 months ago

@Melkiades I reforked the repository to get the latest version of formatters, how do I re-open the current PR?

iaugusty commented 2 months ago

@Melkiades Shall I just start a new PR, or shall I wait until the truetype font PR is completed?

Melkiades commented 2 months ago

, how do I re-open the current PR?

I think it is better to solve all the issue on this PR (even if you want to create a new one) so I can keep track of changes. When you need to update your local clone branch with main it is enough you git pull and main from the original repo should be tracked so no need to close and reopen

iaugusty commented 2 months ago

As I had deleted my fork, the pull request was closed. I have reforked, and commited my changes. However, as the pull request was closed, the below "reopen and comment" button states "the repository that submitted this pull request has been deleted", it doesn't recognize my new reforked version. Do you know an alternative method in github where I can reopen the PR?

Melkiades commented 2 months ago

As I had deleted my fork, the pull request was closed. I have reforked, and commited my changes. However, as the pull request was closed, the below "reopen and comment" button states "the repository that submitted this pull request has been deleted", it doesn't recognize my new reforked version. Do you know an alternative method in github where I can reopen the PR?

I do not know! Try to address my comments and I will review again. I would wait, though for resubmission as soonish you should have rights to branch ;)

fyi @cicdguy @shajoezhu

cicdguy commented 2 months ago

@iaugusty and @gmbecker - you both should be receiving 5 invitations in the mailbox that is associated with your GitHub accounts. One each for tern, formatters, rtables, rlistings, and scda.test. On accepting these invitations, you should have write access to these repos, so you'll no longer need to fork going forward.