search

insightsengineering / formatters

A framework for creating listings of raw data that include specialized formatting, headers, footers, referential footnotes, and pagination.
https://insightsengineering.github.io/formatters/
Other
15 stars 6 forks source link

deprecate args using lifecycle #283

Closed pawelru closed 3 months ago

pawelru commented 3 months ago

follow-up on https://github.com/insightsengineering/formatters/pull/272

fix warnings: https://github.com/r-universe/pharmaverse/actions/runs/8882670125/job/24387876306

  Warning messages:
  1: In FUN(X[[i]], ...) :
    Document references non-existing image: ../help/figures/lifecycle-deprecated.svg
  2: In FUN(X[[i]], ...) :
    Document references non-existing image: ../help/figures/lifecycle-deprecated.svg
  3: In FUN(X[[i]], ...) :
    Document references non-existing image: ../help/figures/lifecycle-deprecated.svg

fix error: https://insightsengineering.github.io/formatters/latest-tag/reference/export_as_pdf.html image

I had some issues identifying from where this is deprecated. The earliest point I managed to find is v0.5.5 https://github.com/insightsengineering/formatters/blob/39377e947637327d60012028f3b1c90cc4b88eb4/R/mpf_exporters.R#L472-L477

github-actions[bot] commented 3 months ago

CLA Assistant Lite bot ✅ All contributors have signed the CLA

pawelru commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

github-actions[bot] commented 3 months ago

Unit Tests Summary

  1 files    8 suites   14s :stopwatch:  48 tests  47 :white_check_mark: 0 :zzz: 1 :x: 335 runs  334 :white_check_mark: 0 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit 69450aa4.

:recycle: This comment has been updated with latest results.