search

insightsengineering / nestdevs-tasks

0 stars 0 forks source link

teal framework Release #66

Open donyunardi opened 1 month ago

donyunardi commented 1 month ago

Summary

We have completed the following enhancements

Let's plan for a release of teal framework packages. We will handle teal modules packages release after this.

Release candidate:

Blockers

teal.data

teal/teal.slice

Deprecation activity

Deprecation activity

Make sure all CI pipelines are green before release (i.e. Scheduled pipeline, etc).

m7pr commented 1 month ago

I think we should do some manual testing on teal.gallery or/and tlg-catalog just in case. Also review if all pipelines/workflows are green once we release (or before we release).

m7pr commented 1 month ago

@donyunardi should we revisit packages for soft deprecated functions and hard deprecate them? Also, for the hard deprecated functions, should we delete them? For example, should we delete all those teal.data functions that got hard deprecated 9 months ago ? https://github.com/insightsengineering/teal.data/blob/main/R/deprecated.R

donyunardi commented 1 month ago

Yeah, good idea. Let's review the deprecated functions in all packages.

For example, should we delete all those teal.data functions that got hard deprecated 9 months ago

I would say yes, 9 months ago is a reasonable time for us to remove this.

m7pr commented 1 month ago

@donyunardi @kumamiao what do you think about planning a community meeting with the summary of what got changed during the release? We could record and put that on YouTube and also include the link to the video in the release notes?

donyunardi commented 1 month ago

Sure, I'm open for it. 👍🏼

donyunardi commented 1 month ago

I think we should do some manual testing on teal.gallery or/and tlg-catalog just in case.

I believe our shinytest2 implementation on teal frameworks and modules covers most of the key areas, but I'm open to doing minimal tests on teal.gallery. For tlg-catalog, I need a better understanding of what requires manual testing.

@m7pr, since you were involved in the shinytest2 implementation, could you help outline any gaps where manual testing is needed for both teal.gallery and tlg-catalog before the release?

Also review if all pipelines/workflows are green once we release (or before we release)

Yes, let's make sure this happens.

kumamiao commented 1 month ago

@donyunardi @kumamiao what do you think about planning a community meeting with the summary of what got changed during the release? We could record and put that on YouTube and also include the link to the video in the release notes?

Sure sounds good, was thinking the same as it's been a while since the last one. I'll be out Nov - Jan, so I was thinking sometime in Jan may be a good timing (assuming this will be aligning with the release timeline - right after the release?), but let's also see how the release work goes.