insightsengineering / nestdevs-tasks

0 stars 0 forks source link

[Bug]: roxy.shinylive is not included in `.pre-commit-config.yaml` #85

Closed averissimo closed 1 month ago

averissimo commented 1 month ago

What happened?

precommit hook fails when this dependency is not on .pre-commit-config.yaml file

Relevant log output

No response

Code of Conduct

Contribution Guidelines

Security Policy

averissimo commented 1 month ago

The 2 PRs still fail with the currently released hooks in version v0.4.3.9001

It uses a PPM version from September, but {roxy.shinylive} requires a dependency released in October ({lzstring} 0.1.2 vs 0.1.3)

We can mitigate by setting export RENV_CONFIG_REPOS_OVERRIDE=https://packagemanager.posit.co/cran/2024-10-28, before commiting.

Should we merge the PRs or just wait until the precommit is updated? I asked the maintainer what's the timeline