insightsengineering / osprey

Community effort to collect TLG code and create a catalogue
https://insightsengineering.github.io/osprey/
Other
4 stars 1 forks source link

revisit scda decoupling #123

Closed m7pr closed 1 year ago

m7pr commented 1 year ago

What is your question?

I think we should apply the same changes to osprey as we did in the follow-up to decoupling at teal.transform https://github.com/insightsengineering/teal.transform/pull/142

Main wishes are

cc @kartikeyakirar @gogonzo

Code of Conduct

Contribution Guidelines

Security Policy

gogonzo commented 1 year ago

prepend dataset names with package names as now we are having the same data in multiple packages (teal.transform::rADAE and teal.modules.general::rADAE for example)

I disagree. osprey is on the top of dependency tree, it doesn't depend on any of teal.* packages.

  • add a data-raw/data.R file to show how the data/ folder was created
  • extend .RBuildignore file to omit data-raw/data.R while building the package

Good point

m7pr commented 1 year ago

what about the situation where you load osprey and then you load some teal.* packages. then the calls to datasets gets clunky as there is a clash in object names being used in multiple packages. the datasets will be used from the last loaded package and can be different