search

insightsengineering / random.cdisc.data

Create random CDISC data
https://insightsengineering.github.io/random.cdisc.data/
Other
30 stars 5 forks source link

Clean up ADSL variables [part 2] #116

Closed shajoezhu closed 2 years ago

shajoezhu commented 2 years ago

Original message

Align ADSL with GDSR spec by doing the following in ADSL:

Original notes:

ui/gdsr-browser-app%23GDSRBrowser?#/default/http%3A%2F%2Fgdsr.roche.com%2Fui%2Fws%2Fdata-analysis-ui%23NavigationScheme.DataAnalysis/view/http%3A%2F%2Fgdsr.roche.com%2Fpd-biometrics%2Fadam-ADSUBv%23Sponsor-Table.ADSUB/gdsr.roche.com)) - AGEU is required but not included here - TRT01P too - on the other hand, for example BEP01FL, BMEASIFL, BMRKR1 are not listed in GDSR but included in this data set. Maybe this is completely fine, I don't know. @waddella for potential comments here. I guess it would just be good if we are clear where the gold standard spec for the RCD datasets is stored. NEST/random.cdisc.data/pull/168/files_ Provenance: ``` Creator: anajens ``` # TODO - Move - [ ] BEP01FL, - [ ] BMEASIFL - [ ] BMRKR1 from `radsl` to `radsub` - Update NEWS.md - Update cadsl, cadsub - update documentation # Definition of done - cadsl has no BEP01FL, BMEASIFL, BMRKR1 - cadsub has BEP01FL, BMEASIFL, BMRKR1
shajoezhu commented 2 years ago

It is ok to process this now, with the downstream changes, we will process in research when dealing with issue https://github.com/insightsengineering/scda.2022/issues/8

codesformochi commented 2 years ago

@shajoezhu - i can do this quickly, but note that for the oncology atezo team we use slightly different variable names and if these are used they're included in ADSL. i checked SKY02 and they also include these in ADSL (their variable names are the same as the atezo team).

do you still want to move these variables to ADSUB?

shajoezhu commented 2 years ago

Thanks Lyndsee @codesformochi ! I just checked, and I can not find that

BEP01FL - Biomarker Evaluable Population Flag BMEASIFL - Response Evaluable Population Flag BMRKR1 - "Continuous Level Biomarker 1"

in neither adsl nor adsub. I will close this issue for now. Lets leave these variables here as they are now. Thanks