search

insightsengineering / random.cdisc.data

Create random CDISC data
https://insightsengineering.github.io/random.cdisc.data/
Other
32 stars 6 forks source link

ADAE: Incorrect Variable Name #223

Closed npaszty closed 1 year ago

npaszty commented 2 years ago

What happened?

believe that ADTHAUT should be AEDTHAUT

found variable in scda.2021 but don't see it in the yaml definition file or in the radae function.

TODO

Replace ADTHAUT to AEDTHAUT

sessionInfo()

don't think this is relevant information for this issue.

Relevant log output

No response

Code of Conduct

Contribution Guidelines

Security Policy

edelarua commented 1 year ago

@npaszty the ADTHAUT variable is in the ADSL dataset in random.cdisc.data and is only inherited from there by ADAE (this is also why it is documented in the ADSL.yml file). According to GDSR when the variable is in ADSL it is named ADTHAUT and when it is in ADAE it is AEDTHAUT. In light of this, is this change still needed (we could make a new AEDTHAUT variable in ADAE if so)?

shajoezhu commented 1 year ago

rename ADTHAUT to AEDTHAUT in adae? what do you think @npaszty

npaszty commented 1 year ago

@shajoezhu @edelarua right! didn't think to look upstream in ADSL. I guess in this case under the RCD context we just leave it alone.