insightsengineering / rlistings

Value formatting and ASCII rendering infrastructure for tables and listings.
https://insightsengineering.github.io/rlistings/
24 stars 5 forks source link

addition of tests for fixes to pagination #192

Closed Melkiades closed 9 months ago

Melkiades commented 9 months ago

Fixes #191 and #183. This should be the real fix for https://github.com/insightsengineering/rlistings/issues/155

github-actions[bot] commented 9 months ago

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              166      25  84.94%   158-161, 164-167, 206-210, 377-380, 384-387, 420-423
TOTAL                      314      40  87.26%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: e016c17117538b6d8b2d7e032b25a21d3d95754d

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 9 months ago

Unit Tests Summary

 1 files   4 suites   5s :stopwatch: 34 tests 27 :white_check_mark:  7 :zzz: 0 :x: 86 runs  75 :white_check_mark: 11 :zzz: 0 :x:

Results for commit e016c171.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 9 months ago

Unit Test Performance Difference

Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | paginate_listing | 👶 | | $+0.15$ | paginate_to_mpfs_works_with_wrapping_on_keycols | | paginate_listing | 👶 | | $+0.34$ | paginate_to_mpfs_works_with_wrapping_on_keycols_when_doing_horizontal_pagination |

Results for commit 77c8a9e7d68517c5fc63d9ada5878d9a1367b5be

♻️ This comment has been updated with latest results.