Add code of conduct and news

insightsengineering / rlistings

Value formatting and ASCII rendering infrastructure for tables and listings.

https://insightsengineering.github.io/rlistings/

25 stars 5 forks source link

Add code of conduct and news #202

Closed Melkiades closed 8 months ago

Melkiades commented 8 months ago

Fixes #188

github-actions[bot] commented 8 months ago

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              166      25  84.94%   158-161, 164-167, 206-210, 377-380, 384-387, 420-423
TOTAL                      314      40  87.26%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 73c091bc6d78e67e05d484827f0d0e552cabfebb

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 8 months ago

Unit Tests Summary

1 files 4 suites 5s :stopwatch: 34 tests 27 :white_check_mark: 7 :zzz: 0 :x: 86 runs 75 :white_check_mark: 11 :zzz: 0 :x:

Results for commit 73c091bc.

:recycle: This comment has been updated with latest results.

shajoezhu commented 8 months ago

hi @Melkiades

can you add some words on using staged dependencies in the contirbution.md file too. thanks!

https://github.com/insightsengineering/rtables/issues/803

Melkiades commented 8 months ago

hi @Melkiades

can you add some words on using staged dependencies in the contirbution.md file too. thanks!

insightsengineering/rtables#803

I checked and it is identical to {tern}. It has also the staged.deps bit ;)

shajoezhu commented 8 months ago

hi @Melkiades can you add some words on using staged dependencies in the contirbution.md file too. thanks! insightsengineering/rtables#803

I checked and it is identical to {tern}. It has also the staged.deps bit ;)

you are right, somehow i remembered wrong. I will close the issue in rtables too. Thanks for checking!

shajoezhu commented 8 months ago

hi @Melkiades can you add some words on using staged dependencies in the contirbution.md file too. thanks! insightsengineering/rtables#803

I checked and it is identical to {tern}. It has also the staged.deps bit ;)

you are right, somehow i remembered wrong. I will close the issue in rtables too. Thanks for checking!

hi @Melkiades , actually, now i remembered, we need to add a sentence for contributors, on how to use staged.dependencies, and stop the downstream checks.

otherwise the installation is not smooth for getting the right branches. i think we will need to add this in all

formatters, rlistings, rtables and tern

Melkiades commented 8 months ago

hi @Melkiades can you add some words on using staged dependencies in the contirbution.md file too. thanks! insightsengineering/rtables#803

I checked and it is identical to {tern}. It has also the staged.deps bit ;)

you are right, somehow i remembered wrong. I will close the issue in rtables too. Thanks for checking!

hi @Melkiades , actually, now i remembered, we need to add a sentence for contributors, on how to use staged.dependencies, and stop the downstream checks.

otherwise the installation is not smooth for getting the right branches. i think we will need to add this in all

formatters, rlistings, rtables and tern

It is not super clear to me what you want to add; I would do it in a different PR once we have created the issues ^^