`fun` argument to `add_listing_col` should probably be deprecated, `na_str` and `align` arguments are untested (but should be kept)

insightsengineering / rlistings

Value formatting and ASCII rendering infrastructure for tables and listings.

https://insightsengineering.github.io/rlistings/

24 stars 5 forks source link

`fun` argument to `add_listing_col` should probably be deprecated, `na_str` and `align` arguments are untested (but should be kept) #218

Open gmbecker opened 2 months ago

gmbecker commented 2 months ago

The fun argument is a very old vestige where we allow the creation of new columns in an existing listing_df and the simultaneous setting of them as display columns, but thats not the UX we ultimately went with and I don't think any code is using it.