insightsengineering / rlistings

Value formatting and ASCII rendering infrastructure for tables and listings.
https://insightsengineering.github.io/rlistings/
24 stars 5 forks source link

Add tests for listing export bug #227

Closed edelarua closed 1 week ago

edelarua commented 1 week ago

See https://github.com/insightsengineering/formatters/pull/323

github-actions[bot] commented 1 week ago

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

edelarua commented 1 week ago

I have read the CLA Document and I hereby sign the CLA

edelarua commented 1 week ago

recheck

github-actions[bot] commented 1 week ago

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------
R/paginate_listing.R        29       0  100.00%
R/rlistings_methods.R      117      26  77.78%   18-29, 49, 65, 69, 155-158, 161, 245-251
R/rlistings.R              181      13  92.82%   176, 385-388, 392-395, 424-427
TOTAL                      327      39  88.07%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 433e92992c5679d0ca28bc0607e41b495ee91a0d

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 1 week ago

Unit Tests Summary

  1 files    5 suites   11s :stopwatch:  39 tests  39 :white_check_mark: 0 :zzz: 0 :x: 120 runs  120 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 433e9299.

github-actions[bot] commented 1 week ago

Unit Tests Summary

  1 files   5 suites   9s :stopwatch:  39 tests 29 :white_check_mark: 10 :zzz: 0 :x: 106 runs  91 :white_check_mark: 15 :zzz: 0 :x:

Results for commit 433e9299.

github-actions[bot] commented 1 week ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
paginate_listing 💚 $6.26$ $-1.05$ $-8$ $+4$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | export | 👶 | | $+0.06$ | export_as_txt_works_with_empty_listings | | export | 👶 | | $+0.20$ | export_as_txt_works_with_listings_with_all_key_cols |

Results for commit 708450915e3f4da7e547b77b9ff5b936f8111d31

♻️ This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Unit Test Performance Difference

Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | export | 👶 | | $+0.06$ | export_as_txt_works_with_empty_listings | | export | 👶 | | $+0.21$ | export_as_txt_works_with_listings_with_all_key_cols |

Results for commit 708450915e3f4da7e547b77b9ff5b936f8111d31

♻️ This comment has been updated with latest results.