search

insightsengineering / scda.2022

An archive of synthetic CDISC data for 2022
https://insightsengineering.github.io/scda.2022/
Other
9 stars 3 forks source link

include updated cache data [part 1] #2

Closed shajoezhu closed 2 years ago

shajoezhu commented 2 years ago

Motivation

Rencent changes updated random cdisc data

TODO

Definition of done

Updated data

yli110-stat697 commented 2 years ago

Hi @shajoezhu I see there are two pending PRs for this package failing automation. Will these be fixed?

shajoezhu commented 2 years ago

Hi @yli110-stat697 , coredev team will help us to initiate this repo for now. Thanks!

shajoezhu commented 2 years ago

Blocked by

codesformochi commented 2 years ago

@shajoezhu - i tried updating the data but it's still not identifying the latest ADSL (i.e. no ADSL.ETHNIC). But when i look in my random.cdisc.data i see ADSL.ETHNIC.

is there something I'm missing?

shajoezhu commented 2 years ago

Hi @codesformochi , at line https://github.com/insightsengineering/scda.2022/blob/main/data_raw/rcd.R#L10, you can see, it is currently pointing to this commit https://github.com/insightsengineering/random.cdisc.data/commit/7f2200332aab693d2ef4149a0f67b7708a2db516,

please update, and point it to "0cc1d7dd8a79db29fff81f68630181ffe1836e83"

It will then resolve the problem :)

codesformochi commented 2 years ago

thanks @shajoezhu ! i thought that might be the case but the commit # was much shorter in gh so i thought maybe not xP didn't know gh shortened commit. i'll give it a try and let you know.

pawelru commented 2 years ago

new snapshot created which is used by tern