insightsengineering / teal.code

Code storage and execution class for teal applications
https://insightsengineering.github.io/teal.code/
Other
11 stars 7 forks source link

Remove magrittr dependency #225

Closed llrs-roche closed 2 days ago

llrs-roche commented 5 days ago

Pull Request

Fixes #224

Checks with --as-cran ran clean. I didn't find any instance where %>% was used in the package and as it is suggested I don't think it will be needed to check teal.gallery or other packages. But no reverse dependencies were done yet.

github-actions[bot] commented 5 days ago

Unit Tests Summary

  1 files   12 suites   3s ⏱️ 145 tests 142 ✅ 3 💤 0 ❌ 224 runs  221 ✅ 3 💤 0 ❌

Results for commit 7a812039.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 5 days ago

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ---------
R/qenv-c.R                          55       0  100.00%
R/qenv-class.R                      12       0  100.00%
R/qenv-concat.R                      7       0  100.00%
R/qenv-constructor.R                 1       0  100.00%
R/qenv-errors.R                      4       4  0.00%    6-9
R/qenv-eval_code.R                  59       2  96.61%   108, 117
R/qenv-extract.R                    30       0  100.00%
R/qenv-get_code.R                   24       0  100.00%
R/qenv-get_env.R                     3       1  66.67%   27
R/qenv-get_messages.r                5       0  100.00%
R/qenv-get_var.R                    26       0  100.00%
R/qenv-get_warnings.R                5       0  100.00%
R/qenv-join.R                        7       7  0.00%    137-151
R/qenv-length.R                      2       1  50.00%   2
R/qenv-show.R                        1       1  0.00%    19
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      189       1  99.47%   240
R/utils.R                           30       0  100.00%
TOTAL                              468      17  96.37%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 7a8120395b40bc3a3531d69fe15d331b9385927a

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

m7pr commented 5 days ago

Hey @llrs-roche good job. Let's wait till Monday to get this merged - unsure if this will break the current changes we are doing on other PR in teal.code