Closed kpagacz closed 2 years ago
@kpagacz
I agree with most of this, a few comments:
The check parameter description is misleading in
cdisc_data
:
I'm not quite sure what it should say to be honest
double call to library(scda) in set_args
That's because we have this:
And I'm not sure we should change it - I might just add comments in the examples to show they are separate
Related to: https://github.com/insightsengineering/coredev-tasks/issues/144
Doubled description in the
Callable
documentation:callable_function
docs need improvements:CallableFunction
- doubled class description:the
check
parameter description is misleading incdisc_data
why are examples in
cdisc_data_connector
not run?weird formatting of parameter descriptions and not uniform format in
cdisc_dataset
double call to
library(scda)
inset_args
is
scda
needed inteal.data::set_keys
?teal.data::to_relational_data
description is unintelligible and it has no examplesscda
is not needed in the example ofteal.data::get_labels