insightsengineering / teal.data

Data model for teal applications
https://insightsengineering.github.io/teal.data/
Other
8 stars 7 forks source link

277 improve `fix_arrows` #287

Closed m7pr closed 7 months ago

m7pr commented 7 months ago

Close #277

github-actions[bot] commented 7 months ago

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  --------------------
R/cdisc_data.R                       1       0  100.00%
R/deprecated.R                      57      57  0.00%    19-344
R/dummy_function.R                   2       2  0.00%    14-15
R/formatters_var_labels.R           36      11  69.44%   60, 69-80
R/join_key.R                        38       0  100.00%
R/join_keys-c.R                     12       0  100.00%
R/join_keys-extract.R              128       0  100.00%
R/join_keys-names.R                 15       0  100.00%
R/join_keys-parents.R               30       0  100.00%
R/join_keys-print.R                 45       0  100.00%
R/join_keys-utils.R                 73       3  95.89%   35-38
R/join_keys.R                       21       0  100.00%
R/teal_data-class.R                 25       1  96.00%   69
R/teal_data-datanames.R             10       0  100.00%
R/teal_data-get_code.R              14       0  100.00%
R/teal_data-show.R                   4       4  0.00%    14-19
R/teal_data.R                       30      16  46.67%   34, 37-43, 53-59, 62
R/testhat-helpers.R                 26       0  100.00%
R/topological_sort.R                32       0  100.00%
R/utils-get_code_dependency.R      170       1  99.41%   268
R/verify.R                          42      11  73.81%   63, 93-97, 100-104
TOTAL                              811     106  86.93%

Diff against main

Filename                         Stmts    Miss  Cover
-----------------------------  -------  ------  -------
R/utils-get_code_dependency.R       +4       0  +0.01%
TOTAL                               +4       0  +0.06%

Results for commit: 61544b9cf79c5492929c44700023dd3f73392b2d

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 7 months ago

Unit Tests Summary

  1 files   14 suites   1s :stopwatch: 175 tests 173 :white_check_mark: 2 :zzz: 0 :x: 245 runs  243 :white_check_mark: 2 :zzz: 0 :x:

Results for commit 61544b9c.

:recycle: This comment has been updated with latest results.

chlebowa commented 7 months ago

LEFT_ASSIGN and RIGHT_ASSIGN are not functions, they are what the parser tells itself when it sees assignment operations.

m7pr commented 7 months ago

RIGHT_ASSIGN functions don't exist

@averissimo that's funny that we missed that haha! Removing the support for those then. I think this is fine to create map dictionary with data.frame function now

m7pr commented 7 months ago

@chlebowa he ment that "->()" and "->>()" do not exist at all

image
m7pr commented 7 months ago

->(x, 5) Error in ->(x, 5) : could not find function "->"

chlebowa commented 7 months ago
> q <- within(qenv(), iris -> i)
> get_code(q)
[1] "i <- iris"

indeed :smile:

m7pr commented 7 months ago

right arrow used as a function not as as an operator