insightsengineering / teal.data

Data model for teal applications
https://insightsengineering.github.io/teal.data/
Other
8 stars 7 forks source link

`topological_sort` for `datanames(teal_data())` #318

Closed m7pr closed 1 month ago

m7pr commented 1 month ago

Part of https://github.com/insightsengineering/teal/pull/1253

The aim of this PR is to apply topological_sort for datanames() of teal_data() object. The order of topological_sort would put parent dataset names before child dataset names.

I located that we need to apply topological_sort for datanames() when

The join_keys specify relation between child and parent, so each time they change the order of topological_sort need to be recalculated.

@averissimo since you are the grand master of join_keys do you see any other place where we should update datanames(teal_data()) when join_keys gets changed? I was thinking about

Would you use your wisdom and shred some light of your thoughts on those 3 remaining methods/functions?

m7pr commented 1 month ago

For now, let's ignore

m7pr commented 1 month ago

Closing in favour of https://github.com/insightsengineering/teal/pull/1280