The aim of this PR is to apply topological_sort for datanames() of teal_data() object. The order of topological_sort would put parent dataset names before child dataset names.
I located that we need to apply topological_sort for datanames() when
we create a new teal_data() object
when we overwrite datanames(x) <- ""
when we overwrite join_keys(x) <- ""
The join_keys specify relation between child and parent, so each time they change the order of topological_sort need to be recalculated.
@averissimo since you are the grand master of join_keys do you see any other place where we should update datanames(teal_data()) when join_keys gets changed? I was thinking about
names(join_keys) <-
parents(join_keys) <-
Would you use your wisdom and shred some light of your thoughts on those 3 remaining methods/functions?
Part of https://github.com/insightsengineering/teal/pull/1253
The aim of this PR is to apply
topological_sort
fordatanames()
ofteal_data()
object. The order oftopological_sort
would put parent dataset names before child dataset names.I located that we need to apply
topological_sort
fordatanames()
whenteal_data()
objectdatanames(x) <- ""
join_keys(x) <- ""
The
join_keys
specify relation between child and parent, so each time they change the order oftopological_sort
need to be recalculated.@averissimo since you are the grand master of
join_keys
do you see any other place where we should updatedatanames(teal_data())
whenjoin_keys
gets changed? I was thinking aboutnames(join_keys) <-
parents(join_keys) <-
Would you use your wisdom and shred some light of your thoughts on those 3 remaining methods/functions?