search

insightsengineering / teal.data

Data model for teal applications
https://insightsengineering.github.io/teal.data/
Other
8 stars 7 forks source link

Change the way IDs are created in `teal_data()` constructor #323

Closed m7pr closed 4 weeks ago

m7pr commented 1 month ago

Follow-up after https://github.com/insightsengineering/teal/pull/1302#discussion_r1711376544 this discussion.

Results of tests

══ Results ═══════════════════════════════════════════════════════
Duration: 4.3 s

── Skipped tests (2) ─────────────────────────────────────────────
• This is not urgent and can be ommitted with @linksto tag. (1):
  test-get_code.R:478:3
• We will not resolve this, as this requires code evaluation.
  (1): test-get_code.R:270:3

[ FAIL 0 | WARN 0 | SKIP 2 | PASS 274 ]
m7pr commented 1 month ago

Yes, Ok! That's why I though that join could break it, but could find the code in join that does that to prove myself wrong : ) Thanks for taking a look

gogonzo commented 1 month ago

@m7pr I think we you close it