insightsengineering / teal.gallery

A Gallery of Exploratory Web Apps used for Analyzing Clinical Trial Data
https://insightsengineering.github.io/teal.gallery/
Other
29 stars 7 forks source link

[Bug]: `{nest_basic-teal_dev}` `Error: object 'IRIS' not found` #135

Closed m7pr closed 8 months ago

m7pr commented 8 months ago

What happened?

Go here https://genentech.shinyapps.io/nest_basic-teal_dev/ and click Show R Code. IRIS used in the code is written with capital letters, the same as MTCARS (instead of iris or mtcars). This brings an error when you run this code in your local session

image
warning('Code was not verified for reproducibility.')
# Add any code to install/load your NEST environment here

library(shiny)
library(teal.code)
library(teal.data)
library(teal.slice)
library(teal)

message('Preprocessing is empty')

stopifnot(rlang::hash(IRIS) == "34844aba7bde36f5a34f6d8e39803508")
stopifnot(rlang::hash(MTCARS) == "d0487363db4e6cc64fdb740cb6617fc0")

IRIS <- dplyr::filter(IRIS, Species == "setosa")
Error: object 'IRIS' not found

Relevant log output

No response

Code of Conduct

Contribution Guidelines

Security Policy

pawelru commented 8 months ago

This is actually not super wrong. You got the warning that the reproducibility is not enabled by the app author: https://github.com/insightsengineering/teal.gallery/blob/0915c6b24fa46053c6a40aab4629781f1d6be51f/basic-teal/app.R#L6

The question is rather: should it be like that taking into account the basicness of the app?

vedhav commented 8 months ago

Thanks for the PR, it's redeployed and works now.

Screenshot 2024-02-14 at 8 33 33 PM
vedhav commented 8 months ago

This is actually not super wrong. You got the warning that the reproducibility is not enabled by the app author:

@pawelru we will merge the dev to main after teal.transform release.

m7pr commented 8 months ago

should it be like that taking into account the basicness of the app?

I think teal.data usage is still basic usage