insightsengineering / teal.gallery

A Gallery of Exploratory Web Apps used for Analyzing Clinical Trial Data
https://insightsengineering.github.io/teal.gallery/
Other
29 stars 7 forks source link

135 fix data in `nest_basic_teal` app #136

Closed m7pr closed 8 months ago

m7pr commented 8 months ago

Close #135

m7pr commented 8 months ago

We either use teal.data::teal_data or we use lowercase letters instead of capitalized IRIS and MTCARS

vedhav commented 8 months ago

Please target the change to dev

pawelru commented 8 months ago

We either use teal.data::teal_data or we use lowercase letters instead of capitalized IRIS and MTCARS

My question was rather: can it be just teal_data(...)

vedhav commented 8 months ago

Okay, I see that this change is already there in dev. So, I think no change is required.

vedhav commented 8 months ago

My question was rather: can it be just teal_data(...)

Yes, we follow using just teal_data without namespace.

m7pr commented 8 months ago

Okay, I see that this change is already there in dev. So, I think no change is required.

So why I am testing outdated https://genentech.shinyapps.io/nest_basic-teal_dev/ ? Should we re-deploy before we start testing https://github.com/insightsengineering/coredev-tasks/issues/489

m7pr commented 8 months ago

@vedhav

dev branch has

data = teal_data(IRIS = iris, MTCARS = mtcars)

but we need

data = teal_data(IRIS = iris, MTCARS = mtcars, code = c("IRIS <- iris;MTCARS <- mtcars"))
m7pr commented 8 months ago

@vedhav would you mind helping to resolve conflicts?

vedhav commented 8 months ago

@vedhav would you mind helping to resolve conflicts?

We'd have to rebase this. Sure, I can do this.

vedhav commented 8 months ago

btw, we don't even need a PR in dev branch as it's not protected 🤫