search

insightsengineering / teal.gallery

A Gallery of Exploratory Web Apps used for Analyzing Clinical Trial Data
https://insightsengineering.github.io/teal.gallery/
Other
29 stars 7 forks source link

[Bug]: Link to the "patient-profile" Stable version doesn't work #156

Closed Nolan-Steed closed 7 months ago

Nolan-Steed commented 7 months ago

What happened?

I tired accessing the "patient-profile" sample app here, but got this message. image

Relevant log output

No response

Code of Conduct

Contribution Guidelines

Security Policy

pawelru commented 7 months ago

Thanks for the report. let me call @vedhav - is this known issue?

vedhav commented 7 months ago

Thanks for reporting. Seeing it for the first time now. The front-end tests in the deployment caught this issue. Maybe it's time to give an error ❌ when this happens, We kept it optional so far. I'll look into this issue.

vedhav commented 7 months ago

Error from the tests:

Error in tm_t_pp_basic_info(label = "Basic Info", dataname = "ADSL", patient_col = "USUBJID",  : 
  Assertion on 'vars' failed: Must inherit from class 'choices_selected', but has class 'data_extract_spec'.
Calls: <Anonymous> ... tm_t_pp_basic_info -> <Anonymous> -> makeAssertion -> mstop
Execution halted
/__w/_actions/cypress-io/github-action/v6/dist/index.js:3900
                error = new Error(`The process '${this.toolPath}' failed with exit code ${this.processExitCode}`);
                        ^
vedhav commented 7 months ago

Even the dev app fails with the same error.

vedhav commented 7 months ago

Good news is that this was not because of some package. As we stopped supporting the des (data_extract_spec) as inputs for tmc we needed to make sure that we use cs (choices_select) in the teal.gallery apps.

pawelru commented 7 months ago

Thanks @vedhav for a prompt response on this!

vedhav commented 7 months ago

Also, the cypress tests are needed for deployments to start so we will not miss such errors in the future.