insightsengineering / teal.gallery

A Gallery of Exploratory Web Apps used for Analyzing Clinical Trial Data
https://insightsengineering.github.io/teal.gallery/
Other
28 stars 7 forks source link

[Feature Request]: Proposition to move teal modules under one tab for each app #176

Open abodoni opened 1 month ago

abodoni commented 1 month ago

Feature description

@Polkas mentioned that there was discussion of the whole NEST in Basel about moving the teal modules under one tab inside each app. For example:

image

image

So for each app (or the ones you agree for) will have three primary tabs: App Info, , Report previewer. Please let me know @kumamiao if you would like me to work on this and if so should I apply it to all teal.gallery apps or just specific ones?

Code of Conduct

Contribution Guidelines

Security Policy

kumamiao commented 2 weeks ago

Thank you @abodoni for raising this issue and willing to collaborate on this! My apologies for the delayed response as I was on vacation earlier. Before @abodoni works on this, @donyunardi just wanted to double check if you're aware of this discussion of combining modules under the same tab? Thanks.

donyunardi commented 2 weeks ago

@kumamiao I don't think I'm aware of this.

@abodoni @Polkas do you recall what's the motivation around this? Is it to display the ability to group modules?

Polkas commented 2 weeks ago

It was discussed and evaluated positively in regards to make the example apps more minimalistic. We discovered that with 3 front modules App Info, Modules and Reporter the app will be well organised. The App Info and Reporter will be well separated which seems desirable. It was discussed almost 2 years ago:p

kumamiao commented 2 weeks ago

Thanks @Polkas for sharing the context. I agree it would be helpful to keep the apps minimalistic, although in the meantime it also adds in the fact that users would need another click before they can see what modules are available.

For example, the "Safety" app is pretty self-explanatory in its name, so does it make sense to further group them under "Safety"? Also the app is currently organized with nested tabs (each tab for a data domain), summarizing all tabs under "Safety" tab would add in another layer of clicking and nesting, which tbh I'm not so sure it would be too much clicking for users and too many layers to navigate. Screen Shot 2024-07-10 at 3 14 02 PM

Although one thing that could be re-organized to make it leaner if you'd like: "Lab Tables" can be renamed as "Labs", and then "Line Plot" tab can be nested under here as it uses the lab data ADLB. Thanks and happy to hear your thoughts.