insightsengineering / teal.goshawk

Modules that produce web interfaces through which longitudinal visualizations can be dynamically
https://insightsengineering.github.io/teal.goshawk/
Other
3 stars 2 forks source link

[Feature Request]: Data constraint choices shouldn't depend on the filtered data #206

Open gogonzo opened 1 year ago

gogonzo commented 1 year ago

Feature description

image

Data constrains currently depends on the filtered data. @npaszty suggested that constraints choices (None, Screening, Baseline) should stay unchanged no matter what happens in the data.

npaszty commented 1 year ago

just to clarify that the data constraint UI element should not have entries removed given right hand data panel filtering. for example

It's important to note that the data constraint filter filters out subjects from the analysis. So it's essentially a dynamic population filter vs. a static ones that are available in the ADSL dataset like SAFFL, MITTFL, ITTFL etc.

npaszty commented 3 months ago

@gogonzo @m7pr

all except correlation plot: see correlation plot related issue #287 . having both "Screening" and "Baseline" constraints displayed when there is no "Screening" visit in the study data creates a problem where if "Baseline" is selected to constrain on and then "Screening" is selected to constrain on the "Baseline" min/max value UI items a=continue to be displayed and if changed while "Screening" is selected will cause a validation message to be printed.