search

insightsengineering / teal.goshawk

Modules that produce web interfaces through which longitudinal visualizations can be dynamically
https://insightsengineering.github.io/teal.goshawk/
Other
3 stars 2 forks source link

Revert update to add new teal.logger shiny input changes feature #298

Closed donyunardi closed 3 months ago

donyunardi commented 3 months ago

As discussed, we will revert the changes to add shiny input changes for teal.goshawk for now so we can move forward with release.

Related to https://github.com/insightsengineering/teal.goshawk/issues/297

github-actions[bot] commented 3 months ago

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

donyunardi commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

github-actions[bot] commented 3 months ago

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        352     352  0.00%    175-594
R/tm_g_gh_correlationplot.R                555     555  0.00%    227-891
R/tm_g_gh_density_distribution_plot.R      278     278  0.00%    135-463
R/tm_g_gh_lineplot.R                       565     565  0.00%    161-820
R/tm_g_gh_scatterplot.R                    245     245  0.00%    144-441
R/tm_g_gh_spaghettiplot.R                  315     315  0.00%    194-590
R/toggleable_slider.R                      154     154  0.00%    72-243
R/utils-arbitrary_lines.r                  125     125  0.00%    19-176
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   49      49  0.00%    12-112
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2910    2910  0.00%

Diff against main

Filename                                 Stmts    Miss  Cover
-------------------------------------  -------  ------  --------
R/tm_g_gh_boxplot.R                         -1      -1  +100.00%
R/tm_g_gh_correlationplot.R                 -1      -1  +100.00%
R/tm_g_gh_density_distribution_plot.R       -1      -1  +100.00%
R/tm_g_gh_lineplot.R                        -1      -1  +100.00%
R/tm_g_gh_scatterplot.R                     -1      -1  +100.00%
R/tm_g_gh_spaghettiplot.R                   -1      -1  +100.00%
R/toggleable_slider.R                       -1      -1  +100.00%
R/utils-arbitrary_lines.r                   -1      -1  +100.00%
TOTAL                                       -8      -8  +100.00%

Results for commit: e17fae2666846975888c6881302b7572082a4923

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

m7pr commented 3 weeks ago

I think we are ready to bring it back https://github.com/insightsengineering/teal.goshawk/issues/317