insightsengineering / teal.goshawk

Modules that produce web interfaces through which longitudinal visualizations can be dynamically
https://insightsengineering.github.io/teal.goshawk/
Other
3 stars 2 forks source link

package level: example data pre-processing code update #8

Open cicdguy opened 3 years ago

cicdguy commented 3 years ago

There is a problem in the example data statements where days and weeks use the name number ranges so the plot example doesn't show proportional x-axis distances.

Current example code yields Screening, Baseline, Week 1, Week 2, etc. -2, 0, 1, 2, etc.

Update should yield Screening, Baseline, Week 1, Week 2, etc. -2, 0, 7, 14, etc.

Provenance:

Creator: npaszty
mhallal1 commented 2 years ago

@npaszty Could we get more information about which example app this comes from?

npaszty commented 2 years ago

I guess when I read the title it's at the package level so all the examples. Week 1 isn't day 1, it's day 7 Week 2 isn't day 2, it's day 14 etc.

gogonzo commented 2 years ago

Assignee: Please check sample app goshawk if it needs this change.