1175 fixing validation on `col_by_var` variable.

insightsengineering / teal.modules.clinical

Provides teal modules for the standard clinical trials outputs

https://insightsengineering.github.io/teal.modules.clinical/

Other

29 stars 13 forks source link

1175 fixing validation on `col_by_var` variable. #1178

Closed kartikeyakirar closed 1 month ago

kartikeyakirar commented 1 month ago

this fixes https://github.com/insightsengineering/teal.modules.clinical/issues/1175

col_by_var is optional. but it fails on deselection.
The issue was resolved by updating the assertion and assigning a NULL value.

github-actions[bot] commented 1 month ago

Unit Tests Summary

1 files 34 suites 4s :stopwatch: 260 tests 150 :white_check_mark: 110 :zzz: 0 :x: 392 runs 170 :white_check_mark: 222 :zzz: 0 :x:

Results for commit 82fddb5b.

:recycle: This comment has been updated with latest results.

m7pr commented 1 month ago

@kartikeyakirar I think it's gonna be more visible if we put col_by_var = NULL to be NULL by default in template_exposure specification, and you can change the condition to

checkmate::assert_character(col_by_var, null.ok = TRUE)

kartikeyakirar commented 1 month ago

col_by_var = NULL to be NULL by default in template_exposure specification, and you can change the condition to

I have added changes here efabf11.Its internal function so I don't see any issue with setting a default value.