search

insightsengineering / teal.modules.clinical

Provides teal modules for the standard clinical trials outputs
https://insightsengineering.github.io/teal.modules.clinical/
Other
32 stars 17 forks source link

[Feature Request]: dynamic encoding based on the filtered data #1235

Open kumamiao opened 1 week ago

kumamiao commented 1 week ago

Feature description

Similar requests have been brought up before in the last round of UI updates, and the decision was to keep teal.slice simple and only performs data slicing and not data manipulation such as dropping factor levels here. So the dynamic filtering would then need to occur on the module level. Happy to hear your thoughts on this @khatril @shajoezhu @donyunardi

User story:

is it possible to have dynamic updating for the encodings based on the active filters?

Here's an example of what I am asking:

Take the Kaplan Meier Plot... if I add ADSL.ARM as an active filter and click off "C: Combination", the Groups for the arm_ref_group do not get updated to omit "C: Combination" as an option. image

Doing so instead results like so:

image "Current ADSL data does not have observations from the reference and comparison treatments."

... which isn't unexpected, but I am wondering if instead we can have it dynamically remove filtered out values?

Code of Conduct

Contribution Guidelines

Security Policy

vedhav commented 1 day ago

This issue is also connected with https://github.com/insightsengineering/teal.goshawk/issues/288 It boils down to whether we should use the filtered or non-filtered data for the encoding panel widget. Each widget can independently choose to use filtered or non-filtered data. In this issue the suggestion is to make use of the filtered data for the draggable buckets widget.