insightsengineering / teal.modules.clinical

Provides teal modules for the standard clinical trials outputs
https://insightsengineering.github.io/teal.modules.clinical/
Other
32 stars 17 forks source link

NEST SUN: tm_t_events feedback #44

Open cicdguy opened 3 years ago

cicdguy commented 3 years ago

Request to have NEST SUN feedback on following items Feedback by EOD Nov. 20th. thanks!

1) Is sorting alphabetically useful? 2) Is it intuitive that the pruning uses "AND" logic? 3) Does it look odd that "content rows" are dropped during pruning? (This is done per GDSR specification but I'm wondering if users expect that?)

NEST/teal.modules.clinical/blob/devel/R/tm_t_events.R) example starts on line 532 Provenance: ``` Creator: npaszty ```
cicdguy commented 3 years ago

Environment: docker image - devel/newest_version

1) I personally like having the alphabetical option in case I'm searching for a CM, or want to check whether a term was included in a basket. I think the original MedDRA order has a specific format (head to toe) so not sure how safety/clin sci would feel. 2) I think this is intuitive, especially if you starting playing with both. It might be worth adding a disclaimer under the "Pruning Options" or maybe including "and" between the fields? 3) I understand "content rows" to mean the "Total number of patients with at least one event" or similar. And I would expect to have that present.

Not sure if this is just me, but I think with incidence/difference between it's easy to forget what % I chose because the contents of the table still look relatively the same (in contrast, if I filter by a particular patient, or category, it's easier to tell by looking at the table). Is there a way to print this at the top of the table? - sorry if this is out of scope, just a thought.

Thanks! Lyndsee

Provenance:

Creator: codesformochi
yangx61 commented 2 years ago

No required actions. Possible enhancement @shajoezhu